Skip to content

fix: check for double definition#15670

Merged
ishitasequeira merged 3 commits intoargoproj:masterfrom
blakepettersson:fix/managed-namespace-vs-manifest-check
Nov 8, 2023
Merged

fix: check for double definition#15670
ishitasequeira merged 3 commits intoargoproj:masterfrom
blakepettersson:fix/managed-namespace-vs-manifest-check

Conversation

@blakepettersson
Copy link
Member

@blakepettersson blakepettersson commented Sep 26, 2023

As found in #13965 (and as a follow-up to #13999), we also need to define what happens if both managedNamespaceMetadata and an Application manifest are defined for the same namespace.

The idea here is that if that happens, we emit an
ApplicationConditionRepeatedResourceWarning, and set the sync status to Unknown, since it's unclear what is supposed to happen.
the managedNs doesn't get added to the list of targetObjs if there is already a source definition of the namespace.

Fixes #15815

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression on Managed Namespace Metadata Option

4 participants