fix: check for double definition#15670
Merged
ishitasequeira merged 3 commits intoargoproj:masterfrom Nov 8, 2023
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As found in #13965 (and as a follow-up to #13999), we also need to define what happens if both
managedNamespaceMetadataand an Application manifest are defined for the same namespace.The idea here is that if that happens,
we emit an
theApplicationConditionRepeatedResourceWarning, and set the sync status toUnknown, since it's unclear what is supposed to happen.managedNsdoesn't get added to the list oftargetObjsif there is already a source definition of the namespace.Fixes #15815
Checklist: